Re: [PATCH] gpu: host1x: Use direct DMA with IOMMU API usage

From: Thierry Reding
Date: Thu Feb 07 2019 - 03:51:37 EST


On Wed, Feb 06, 2019 at 02:08:33PM -0800, Guenter Roeck wrote:
> On Fri, Feb 01, 2019 at 02:28:26PM +0100, Thierry Reding wrote:
> > If we use the IOMMU API directly to map buffers into host1x' IOVA space,
> > we must make sure that the DMA API doesn't already set up a mapping, or
> > else translation will fail.
> >
> > The direct DMA API allows us to allocate memory that will not be mapped
> > through an IOMMU automatically.
> >
> > Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
>
> arm64:defconfig:
>
> ERROR: "dma_direct_free" [drivers/gpu/host1x/host1x.ko] undefined!
> ERROR: "dma_direct_alloc" [drivers/gpu/host1x/host1x.ko] undefined!

Hi Guenter,

I sent out a fix to export dma_direct_alloc() and dma_direct_free() but
Christoph preferred not to merge that, so I'm currently working on a
different solution for this. I hope to have a fix for this by the end of
the day, but if not I'll back out the above commit.

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature