Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

From: Maxime Ripard
Date: Fri Feb 08 2019 - 02:45:04 EST

On Thu, Feb 07, 2019 at 09:46:23AM -0800, Yizhuo wrote:
> In function sun8i_dwmac_set_syscon(), local variable "val" could
> be uninitialized if function regmap_read() returns -EINVAL.
> However, it will be used directly in the if statement, which
> is potentially unsafe.
> Signed-off-by: Yizhuo <yzhai003@xxxxxxx>

Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>


Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering

Attachment: signature.asc
Description: PGP signature