Re: [RFT PATCH 7/9] mfd: axp20x: add USB power supply mfd cell to AXP813

[Lee Jones]

On Thu, 07 Feb 2019, Chen-Yu Tsai wrote:

> On Thu, Feb 7, 2019 at 7:02 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >
> > On Thu, 07 Feb 2019, Chen-Yu Tsai wrote:
> >
> > > From: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
> > >
> > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver
> > > supports this variant, we can add an mfd cell for it to use it.
> > >
> > > Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
> > > [wens@xxxxxxxx: add commit message]
> > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
> > > ---
> > >  drivers/mfd/axp20x.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> > > index 3c97f2c0fdfe..17b115845993 100644
> > > --- a/drivers/mfd/axp20x.c
> > > +++ b/drivers/mfd/axp20x.c
> > > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = {
> > >       DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"),
> > >  };
> > >
> > > +/* AXP803 and AXP813/AXP818 share the same interrupts */
> > > +static struct resource axp803_usb_power_supply_resources[] = {
> > > +     DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"),
> > > +     DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"),
> >
> > Nit: Why 2 spaces here?                              ^
> 
> 2 spaces? I'm only seeing one.

Eh, that's odd.  My eyes must be failing me.

Just add my Ack then. :)

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog