Re: [PATCH v11 00/16] Remove nested TPM operations

From: Stefan Berger
Date: Fri Feb 08 2019 - 07:05:36 EST


On 2/8/19 6:14 AM, Jarkko Sakkinen wrote:
On Thu, Feb 07, 2019 at 08:51:15PM -0500, Stefan Berger wrote:
+ÂÂÂ rc = 0;
ÂÂÂÂ if (chip->flags & TPM_CHIP_FLAG_IRQ)
ÂÂÂÂ ÂÂÂ goto out_recv;
What why?

This fix seems to only be necessary when bisecting. You may want to apply
it!
I don't want to apply it because I don't understand why it would
be needed. Can you give a short explanation?


See my comment on [PATCH v11 08/16]. It needs to be added in that patch since otherwise rc holds a non-zero value on function exit, which is wrong at that point.



/Jarkko