Re: [PATCH 1/2] tpm: Unify the send callback behaviour
From: Jarkko Sakkinen
Date: Fri Feb 08 2019 - 10:42:56 EST
On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote:
> At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) are also
> returning the number of bytes sent. I would consider tpm_crb the outlier
> that returns 0 and should return the length even though we don't need it...
That would be absolutely wrong way the fix the *actual* issue i.e.
callbacks returning garbage (sometimes just passing the length parameter
back as a return value).