Re: [PATCH 1/4] component: Add documentation

[Daniel Vetter]

On Fri, Feb 8, 2019 at 4:29 PM Daniel Vetter <daniel@xxxxxxxx> wrote:
>
> On Fri, Feb 08, 2019 at 12:51:23PM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Feb 08, 2019 at 12:27:56AM +0100, Daniel Vetter wrote:
> > > While typing these I think doing an s/component_master/aggregate/
> > > would be useful:
> > > - it's shorter :-)
> > > - I think component/aggregate is much more meaningful naming than
> > >   component/puppetmaster or something like that. At least to my
> > >   English ear "aggregate" emphasizes much more the "assemble a pile of
> > >   things into something bigger" aspect, and there's not really much
> > >   of a control hierarchy between aggregate and constituing components.
> > >
> > > But that's way more than a quick doc typing exercise ...
> > >
> > > Thanks to Ram for commenting on an initial draft of these docs.
> > >
> > > v2: Review from Rafael:
> > > - git add Documenation/driver-api/component.rst
> > > - lots of polish to the wording + spelling fixes.
> > >
> > > v3: Review from Russell:
> > > - s/framework/helper
> > > - clarify the documentation for component_match_add functions.
> > >
> > > v4: Remove a few superflous "This".
> > >
> > > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > Cc: "C, Ramalingam" <ramalingam.c@xxxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> > > Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> > > Cc: Jaroslav Kysela <perex@xxxxxxxx>
> > > Cc: Takashi Iwai <tiwai@xxxxxxxx>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> > > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> >
> > Thanks for doing this!
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Thanks for reviewing (obviously includes Rafael and Russell too)!
>
> For merging I see two options:
> - All through drm-intel, but will only land in 5.2 because the feature
>   cut-off has already happened for i915. So a bit awkward.
> - Topic branch with the 2 component patches plus the snd-hda/drm-i915
>   patch, so that you/Takashi/drm can pull it in as needed. The drm
>   component doc patch (3/4 in this series) I can pull in later on.
>
> Greg/Takashi, any preferences?

Just realized that for the mei side of this series I need a topic
branch anyway, so topic branch it is. I'll prep that so that CI can
beat on it over the w/e, and we can rebase the i915/mei series on top,
and then send out the topic pull to everyone early next week. You can
then all decide whether you need it or not.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch