Re: [PATCH] dt-bindings: pinctrl: Document the i.MX50 IOMUXC binding

[Jonathan NeuschÃfer]

On Fri, Feb 08, 2019 at 09:57:04AM -0200, Fabio Estevam wrote:
> Hi Jonathan,
> 
> On Tue, Jan 29, 2019 at 2:55 PM Jonathan NeuschÃfer
> <j.neuschaefer@xxxxxxx> wrote:
> >
> > AFAICS from the i.MX50 Reference Manual, the i.MX50 IOMUXC works the
> > same as the one in i.MX51, so I copied fsl,imx51-pinctrl.txt and changed
> > the text to imx50.
> >
> > Signed-off-by: Jonathan NeuschÃfer <j.neuschaefer@xxxxxxx>
> > Cc: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>
> 
> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>

Thanks!

> > +Required properties:
> > +- compatible: "fsl,imx50-iomuxc"
> > +- fsl,pins: two integers array, represents a group of pins mux and config
> > +  setting. The format is fsl,pins = <PIN_FUNC_ID CONFIG>, PIN_FUNC_ID is a
> > +  pin working on a specific function, CONFIG is the pad setting value like
> > +  pull-up for this pin. Please refer to imx50 datasheet for the valid pad
> 
> Nit: It is the i.MX50 Reference Manual, not its datasheet that
> describes the pad settings values.

Indeed, good catch.

> I noticed that all the bindings say datasheet though, so I will send a
> patch to fix this.

Thanks!


Jonathan NeuschÃfer

Attachment: signature.asc
Description: PGP signature