Re: [PATCH] Input: ps2-gpio - flush TX work when closing port

From: Danilo Krummrich
Date: Fri Feb 08 2019 - 11:00:50 EST

On 2019-02-08 08:31, Dmitry Torokhov wrote:
On Thu, Feb 07, 2019 at 06:03:03PM -0500, Sven Van Asbroeck wrote:
On Thu, Feb 7, 2019 at 5:27 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> + flush_work(&drvdata->;

Would cancel_work_sync() be better than flush_work() ?

No, because we want to have interrupt and gpios in a consistent state.
If we cancel then we need to see if we should disable it or it may
already be disabled, etc. This way we know it is enabled after
flush_delayed_work() returns, and we need to disable it.


I agree with Dmitry - thanks for the fix.

Acked-by: Danilo Krummrich <danilokrummrich@xxxxxxxxxxxxx>