Re: [PATCH 25/35] ARM: davinci: cp-intc: use the new-style config structure
From: Bartosz Golaszewski
Date: Fri Feb 08 2019 - 11:27:36 EST
wt., 5 lut 2019 o 01:29 David Lechner <david@xxxxxxxxxxxxxx> napisaÅ(a):
> On 1/31/19 7:39 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > Modify the cp-intc driver to take all its configuration from the new
> > config structure. Stop referencing davinci_soc_info in any way.
> > Move the declaration for davinci_cp_intc_init() to
> > irq-davinci-cp-intc.h and make it take the new config structure as
> > parameter. Convert all users to the new version.
> > Also: since the two da8xx SoCs default all irq priorities to 7, just
> > drop the priority configuration at all and hardcode the channels to 7.
> As mentioned in a comment on a different patch, this isn't strictly
> true (although in practice, it probably is).
> This patch deletes a code path with the comment "Default everything
> to channel 15 if priority not specified.", so it is possible (although
> unlikely) that this patch could change a priority of some IRQ that is
> being used.
This only happens if no priorities are specified. Otherwise we just
iterate over the provided array and set priorities for all interrupts.
> > It will simplify the driver code and make our lives easier when it
> > comes to device-tree support.
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > ---