Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourÃ

From: Stefan Berger
Date: Fri Feb 08 2019 - 14:27:43 EST


On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:

*/
if (rc > 0) {
dev_warn(&chip->dev,
"%s: send(): invalid value %d\n", __func__, rc);
rc = 0;
}

Should be fairly safe play now.

Unfortuantely it isn't. You seemed to have lost the EXPORT_SYMBOL_GPL(tpm_chip_start/stop) and the tpm_chip_start/stop around the tpm2_shutdown()...



/Jarkko