Re: [PATCH RESEND] initramfs: cleanup incomplete rootfs

From: Andrew Morton
Date: Fri Feb 08 2019 - 17:08:14 EST

On Fri, 8 Feb 2019 21:45:21 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Tue, Oct 30, 2018 at 5:22 PM David Engraf <david.engraf@xxxxxxxxx> wrote:
> >
> > Unpacking an external initrd may fail e.g. not enough memory. This leads
> > to an incomplete rootfs because some files might be extracted already.
> > Fixed by cleaning the rootfs so the kernel is not using an incomplete
> > rootfs.
> This breaks my setup where I have U-boot provided more size of
> initramfs than needed. This allows a bit of flexibility to increase or
> decrease initramfs compressed image without taking care of bootloader.
> The proper solution is to do this if we sure that we didn't get enough
> memory, otherwise I can't consider the error fatal to clean up rootfs.

OK, thanks. Maybe David can suggest a fix - I'll queue up a revert

I don't really understand the failure. Why does an oversized initramfs
cause unpack_to_rootfs() to fail?