Re: [PATCH 0/4] crypto: caam - add ecb mode support

From: Eric Biggers
Date: Sat Feb 09 2019 - 16:52:35 EST

Hi Iuliana,

On Fri, Feb 08, 2019 at 03:50:06PM +0200, Iuliana Prodan wrote:
> This patch set adds ecb mode support for aes, des, 3des and arc4 ciphers.
> skcipher implementation is reused, making sure to handle the no IV case.
> While here:
> -fix a DMA API issue where initial src/dst_nents are used instead of nents
> returned by dma_map_sg()
> -export arc4 defines in a common header
> -update cbc des and 3des to check for weak keys
> Iuliana Prodan (4):
> crypto: caam - use mapped_{src,dst}_nents for job descriptor
> crypto: export arc4 defines
> crypto: caam - add ecb(*) support
> crypto: caam - weak key checking for cbc des, 3des

Do you have an actual use case for adding more DES, 3DES, and ARC4
implementations, or are you simply adding them because the hardware happens to
supports it? These old ciphers are insecure, so IMO more implementations should
only be added if there is a real use case where they're absolutely needed.

- Eric