Re: [PATCH] MAINTAINERS: use tab instead of spaces
From: Joe Perches
Date: Sun Feb 10 2019 - 21:21:50 EST
On Sun, 2019-02-10 at 10:25 -0800, James Bottomley wrote:
> On Sun, 2019-02-10 at 19:10 +0100, Lukas Bulwahn wrote:
> > Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen
> > as
> > further maintainer to the KEYS-TRUSTED section entry. So, we rectify
> > this
> > with this commit.
> > The issue was detected when writing a script that parses MAINTAINERS.
> > Fixes: 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for
> > trusted keys")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> This isn't really a bug, is it?
No, it's a style defect.
> We have no formatting requirements for the MAINTAINERS file and the
> section owner is free to align with tabs, spaces or nothing as they see
> fit. Most use a single tab, but a couple don't. The only real thing
> that cares is get_maintainers.pl and it uses \s* as the parse regexp,
> so it doesn't care either.
It doesn't 'care' because get_maintainer is designed
to work with badly formatted entries.
checkpatch does emit warnings for MAINTAINER entries
that use anything other than a single tab.