Re: [PATCH v5 0/10] Add support for OLPC XO 1.75 Embedded Controller
From: Lubomir Rintel
Date: Mon Feb 11 2019 - 06:46:48 EST
On Thu, 2019-01-10 at 18:58 +0100, Lubomir Rintel wrote:
> Hello!
>
> This is a fifth spin of the patch set that adds support for the Embedded
> Controller on an OLPC XO 1.75 machine.
>
> It notably removes the patches that adjust the battery driver -- those were
> submitted to linux-pm separately [1].
>
> [1] https://lore.kernel.org/lkml/20190110174005.1202564-1-lkundrak@xxxxx/T/#m9da9aee9e6482ee680a103280ebb769ebcbb32ef
>
> This DT bindings doc is pretty much independent of the above:
>
> [01/10] dt-bindings: olpc,xo1.75-ec: Add OLPC XO-1.75 EC
>
> The OLPC EC changes follow. Cleanups first, then functionality:
>
> [02/10] Platform: OLPC: Remove an unused include
> [03/10] Platform: OLPC: Move EC-specific functionality out from
> [04/10] Platform: OLPC: Avoid a warning if the EC didn't
> [05/10] Platform: OLPC: Use BIT() and GENMASK() for event masks
> [06/10] Platform: OLPC: Add XO-1.75 EC driver
> [07/10] Platform: OLPC: Add a regulator for the DCON
>
> The patch 08/10 only makes sense once both the above and the XO 1.75
> battery support is merged, otherwise enabling CONFIG_BATTERY_OLPC on
> ARM would break build.
>
> [08/10] power: supply: olpc_battery: Allow building the driver
>
> The restart support has been split off, because there's a possibility it
> needs to be reworked: the arm_pm_restart export patch was objected to:
>
> [09/10] ARM: export arm_pm_restart
> [10/10] Platform: OLPC: Add restart support to XO-1.75 EC
>
> Tested to work on an OLPC XO 1.75 and also tested not to break x86
> support with an OLPC XO 1 machine. I don't have a XO 1.5, but it's
> unlikely this breaks it when XO 1 works.
Hello Andy & Darren,
I'm wondering if there's anything more I need to do in order for the
patches 01-07 to be queued for 5.1? I believe I addressed the issues
that were pointed out and I believe the patch set is already in a good
shape.
Thanks,
Lubo