Re: [PATCH 1/2] selftests/x86/fsgsbase: Indirect output through a wrapper function

From: Mark Brown
Date: Mon Feb 11 2019 - 08:02:08 EST

On Mon, Feb 11, 2019 at 09:45:43AM +0100, Ingo Molnar wrote:
> * Mark Brown <broonie@xxxxxxxxxx> wrote:

> > In preparation for a change to make this test run repeatedly which
> > would generate huge amounts of output as is indirect all the printf()
> > calls in the program through a wrapper and add a quiet flag which can
> > be used to suppress the output. This is fairly quick and dirty, I'm not
> > 100% sure what would be idiomatic here.

> So this really loses useful output when there is a failure. After this
> patch I get:

> dagon:~/tip/tools/testing/selftests/x86> ./fsgsbase_64 -vv
> [FAIL] 24 errors detected in 1 tries

> Not very helpful, and no real command-line way to see the failures.

For clarity it's the second patch that breaks this, though you're right
this isn't helpful and this patch needs a log level adding to really fix

Attachment: signature.asc
Description: PGP signature