Re: [GIT PULL] signal fixes for v5.0-rc6

From: Oleg Nesterov
Date: Mon Feb 11 2019 - 11:48:05 EST


On 02/08, Eric W. Biederman wrote:
>
> signal: Always notice exiting tasks

Sorry, I could not look at these patches before...

So I think this one should be reverted, it makes PTRACE_EVENT_EXIT even more broken.

Once again, why we can't do something like

--- x/kernel/signal.c
+++ x/kernel/signal.c
@@ -209,6 +209,8 @@ int next_signal(struct sigpending *pendi
*/
x = *s &~ *m;
if (x) {
+ if (x & sigmask(SIGKILL))
+ return SIGKILL;
if (x & SYNCHRONOUS_MASK)
x &= SYNCHRONOUS_MASK;
sig = ffz(~x) + 1;

instead? at least for the start.

Oleg.