Re: [PATCH] vmw_balloon: release lock on error in vmballoon_reset()

From: Nadav Amit
Date: Mon Feb 11 2019 - 14:12:58 EST


> On Feb 11, 2019, at 10:45 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> We added some locking to this function but forgot to drop the lock on
> these two error paths. This bug would lead to an immediate deadlock.
>
> Fixes: c7b3690fb152 ("vmw_balloon: stats rework")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Cc: stable@xxxxxxxxxxxxxxx
Reviewed-by: Nadav Amit <namit@xxxxxxxxxx>

--

Yes, I screwed up. Thanks for catching it!

Iâll go to check why my error injection tests didnât catch it.