Re: [PATCH 4.20 081/352] f2fs: avoid build warn of fall_through

[Stephen Rothwell]

Hi Greg,

On Mon, 11 Feb 2019 15:15:08 +0100 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> 4.20-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> [ Upstream commit f5d5510e7389fa264337fb524346bac9eb93adc8 ]
> 
> After merging the f2fs tree, today's linux-next build
>  (x86_64_allmodconfig) produced this warning:
> 
>  In file included from fs/f2fs/dir.c:11:
>  fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>  fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     if (set)
>        ^
>  fs/f2fs/f2fs.h:2390:2: note: here
>    case FI_DATA_EXIST:
>    ^~~~
> 
>  Exposed by my use of -Wimplicit-fallthrough

Does the 4.20 stable tree use -Wimplicit-fallthrough?  I assume not
(since v4.20 doesn't), so this warning does not happen in that tree.
-- 
Cheers,
Stephen Rothwell

Attachment: pgpizxkeeEQjg.pgp
Description: OpenPGP digital signature