Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

[Luis Chamberlain]

On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote:
> On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote:
> > On Mon, Feb 11, 2019 at 01:06:32PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > 
> > > @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v
> > 
> > > -			if ((min && val < *min) || (max && val > *max))
> > > -				continue;
> > > +			if ((min && val < *min) || (max && val > *max)) {
> > > +				err = -EINVAL;
> > 
> > I was asked to return ERANGE in kstrto*().
> 
> I think we discussed ERANGE vs EINVAL and decided EINVAL because there
> was precedence for other sysctls already.

Can you do a proper audit and see?

linux-api folks may care.

 Luis