Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors
From: John Sperbeck
Date: Mon Feb 11 2019 - 16:44:10 EST
On Mon, Feb 11, 2019 at 6:24 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Sun, 10 Feb 2019 19:40:21 -0800
> John Sperbeck <jsperbeck@xxxxxxxxxx> wrote:
> > If an smbus transfer fails, there's no guarantee that the output
> > buffer was written. So, avoid trying to show the output buffer when
> > tracing after an error. This was 'mostly harmless', but would trip
> > up kasan checking if left-over cruft in byte 0 is a large length,
> > causing us to read from unwritten memory.
> This looks fine to me, but I'm not sure how the i2c maintainers feel,
> but I always require that a new patch version starts a new thread, and
> not be part of a older thread release (causes these patches to be
> hidden from those that read patches in threading mode).
That sounds reasonable to me. Unless I hear otherwise, I'll create a
v3 as a new thread. Thanks.