Re: [GIT PULL] Thermal-SoC management fixes for v5.0-rc6

From: Konstantin Ryabitsev
Date: Mon Feb 11 2019 - 18:10:23 EST

On Mon, Feb 11, 2019 at 02:04:08PM -0800, Linus Torvalds wrote:
Okay, so I need guidance on the proper behaviour here. As this request
didn't use the magic wording for the commit-id (as generated by
git-request-pull), we ended up trying to look up the remote. The remote
specified was:

git:// fixes

Since it's a short refname, we first try to look it up as a tag:

No, you don't do even that.

The name is "fixes". But you seem to match it with one of these:

$ git ls-remote git:// fixes^{}
a6d25f4c951b8b28f2eaec6f891ff834622532f2 refs/tags/omap-for-v3.10-rc1/fixes^{}
77319669af37a1cfc844b801e83343b37e3c7e13 refs/tags/omap/fixes^{}

*NEITHER* of which is a tag named "fixes". One is named
"omap-for-v3.10-rc1/fixes" and the other is a tag named "omap/fixes".


Thank you for the feedback. I've implemented a fix that handles shortname refs more properly in order to avoid hitting this problem again.