Re: [PATCH v3 1/4] mfd: max77620: Add backup battery charger support

[Lee Jones]

On Tue, 12 Feb 2019, Mark Zhang wrote:

> Add PMIC configurations for backup battery charger, which
> is a constant voltage and constant current style charger
> with a series output resistance.
> 
> The max77620 register CNFGBBC(addr: 0x04) defines the
> parameters of backup battery charger. This patch adds
> support for it.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Signed-off-by: Venkat Reddy Talla <vreddytalla@xxxxxxxxxx>
> Signed-off-by: Mark Zhang <markz@xxxxxxxxxx>
> ---
>  drivers/mfd/max77620.c | 80 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 80 insertions(+)

My previous review comments still apply.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog