Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator
From: Andy Shevchenko
Date: Tue Feb 12 2019 - 05:21:51 EST
On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
> Commit a893ea15d764 ("tpm: move tpm_chip definition to
> include/linux/tpm.h") introduced a build error when both ima and efi is
> enabled. What happens is that both headers (ima.h and efi.h) defines the
> same 'NONE' constant, and it broke when they started getting included
> from the same file.
> We only need one of the two patches applied.
I would argue that we need two patches applied. Namespace is a hidden
issue in the code.
This patch looks good to me, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
With Best Regards,