Re: [PATCH 09/10] platform/x86: intel_pmc_core: Add Package cstates residency info
From: Andy Shevchenko
Date: Tue Feb 12 2019 - 05:25:23 EST
On Mon, Feb 11, 2019 at 8:32 PM Bhardwaj, Rajneesh
> On 11-Feb-19 10:11 PM, Anshuman Gupta wrote:
> > On Fri, Feb 01, 2019 at 01:02:33PM +0530, Rajneesh Bhardwaj wrote:
> >> This patch introduces a new debugfs entry to read current Package
> >> cstate residency counters. A similar variant of this patch was discussed
> >> earlier "https://patchwork.kernel.org/patch/9908563/" but didn't make it
> >> into mainline for various reasons. Current version only adds debugfs
> >> entry which is quite useful for S0ix debug but excludes the exported API
> >> that was there in initial version. Though there are tools like turbostat
> >> and socwatch which can also show this info but sometimes its more
> >> practical to have it here as it's hard to switch between various tools for
> >> S0ix debug when pmc_core driver is the primary debug tool. Internal and
> >> external customers have requested for this patch to be included in the
> >> PMC driver on many occasions and Google Chrome OS team has already included
> >> it in their builds. This becomes handy when requesting logs from external
> >> customers who may not always have above mentioned tools in their integrated
> >> kernel builds.
> > Tested-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx>
> > Acked-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx>
> Hi Andy, Darren - Can i used Acked-and-tested-by instead of these two?
Better to split. I didn't see in common practice acked-and-tested.
Rather reviewed-and-tested, or reported-and-tested.
With Best Regards,