Re: [PATCH V2 1/4] genirq/affinity: store irq set vectors in 'struct irq_affinity'

From: Thomas Gleixner
Date: Tue Feb 12 2019 - 08:35:42 EST


On Tue, 12 Feb 2019, Ming Lei wrote:

> Currently the array of irq set vectors is provided by driver.
>
> irq_create_affinity_masks() can be simplied a bit by treating the
> non-irq-set case as single irq set.
>
> So move this array into 'struct irq_affinity', and pre-define the max
> set number as 4, which should be enough for normal cases.

You really want to add some sanity check which makes sure, that nr_sets is
<= IRQ_MAX_SETS.

Thanks,

tglx