Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

From: Vineet Gupta
Date: Tue Feb 12 2019 - 12:34:19 EST

On 2/12/19 9:25 AM, Eugeniy Paltsev wrote:
>> This is technically changing the ABI - I think we don't need to enforce this -
>> keep ignoring this
> I think it's better to add this check:
> * This check doesn't break backward compatibility. ARC U-boot pass zero to r1
> from the beginnings, I specially checked this. So we doesn't change ABI,
> we only document it ;)

OK good.

> * By adding this check we can cheap and easily minimize problems in JTAG case.

Prior to your patch this register was irrelevant - it didn't matter for jtag or
uboot cause what its value was since it was not being checked at all. Now you
enforce this be 0. Simple reasoning tells me it will likely cause problems, if
any, but won't reduce them at all. So I'd insist we keep ignoring it even if uboot
was zeroing it out. Atleast this leaves the door open any future changes.