Re: [PATCH v6 5/9] vsprintf: Factor out %pV handler as va_format()
From: Joe Perches
Date: Tue Feb 12 2019 - 12:58:34 EST
On Tue, 2019-02-12 at 14:00 +0100, Petr Mladek wrote:
> On Fri 2019-02-08 09:11:17, Joe Perches wrote:
> > On Fri, 2019-02-08 at 16:23 +0100, Petr Mladek wrote:
> > > Move the code from the long pointer() function. We are going to improve
> > > error handling that will make it more complicated.
> > >
> > > This patch does not change the existing behavior.
> > But doesn't this increase stack use?
> > %pV is recursive and increasing the stack is undesired
> > for this use.
> %pV handler is stack sensitive because the entire vsnprintf()
> machinery is called recursively. This one extra call does
> not make it much worse.
That's an argument?.
Refactoring is good, but you need to add