Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

From: Randy Dunlap
Date: Tue Feb 12 2019 - 19:05:02 EST

On 2/12/19 3:49 PM, Nick Crews wrote:
> OK, here is the patch to fix this problem. We had the dependency backwards.
> Should I re-send out the entire patch series to the LKML with this fix in it?
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index 462eb9dfa4f2..b69561050868 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -95,7 +95,7 @@ config CROS_EC_LPC
> Â
> Â Â Â Â bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
> -Â Â Â Âdepends on CROS_EC_LPC || WILCO_EC
> +Â Â Â Âdepends on CROS_EC_LPC
> Â Â Â Â default n
> Â Â Â Â help
> Â Â Â Â Â If you say Y here, a variant LPC protocol for the Microchip EC
> diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
> index d8e2cddb4712..6ea2d3f64ce5 100644
> --- a/drivers/platform/chrome/wilco_ec/Kconfig
> +++ b/drivers/platform/chrome/wilco_ec/Kconfig
> @@ -1,6 +1,6 @@
> Âconfig WILCO_EC
> Â Â Â Â tristate "ChromeOS Wilco Embedded Controller"
> -Â Â Â Âdepends on ACPI && X86
> +Â Â Â Âdepends on ACPI && X86 && CROS_EC_LPC_MEC
> Â Â Â Â select CROS_EC_LPC_MEC
> Â Â Â Â help
> Â Â Â Â Â If you say Y here, you get support for talking to the ChromeOS

Hi Nick,

Your emails contain html and are not being archived by
or by Please fix that (no html) and resend the patch.

I don't know the answer to your question. I would expect that whoever
merged the current drivers/platform/chrome/wilco_ec/ source files
could/would just take the new Kconfig patch and merge it also.