Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

From: Alexei Starovoitov
Date: Tue Feb 12 2019 - 21:49:28 EST

On Tue, Feb 12, 2019 at 6:15 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
> Do not add more debugging stuff unless you can demonstrate
> they actually allowed you to find a real bug and that you sent a
> public fix for it.
> Just adding "cool stuff" in TCP stack does not please me, it is only
> more complexity for unproven gain.

I agree.
I don't see why this debugging of 'abnormal TCP' cannot be done
with kprobes and tracepoints.
Instrumenting every tcp counter increment is overkill.