Re: [PATCH] xen: mark expected switch fall-through

From: Juergen Gross
Date: Wed Feb 13 2019 - 00:51:05 EST


On 13/02/2019 00:50, Boris Ostrovsky wrote:
> On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/xen/xen-pciback/xenbus.c: In function âxen_pcibk_frontend_changedâ:
>> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (xenbus_dev_is_online(xdev))
>> ^
>> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
>> case XenbusStateUnknown:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Applied to for-linus-5.0
>
> (xen-scsiback patch too)

I'm tending to delay those patches until 5.1, as we are pretty late in
the 5.0 cycle. We should add only really critical fixes to 5.0 now.


Juergen