Re: [PATCH -tip v3 05/10] kprobes: Search non-suffixed symbol in blacklist
From: Ingo Molnar
Date: Wed Feb 13 2019 - 02:17:18 EST
* Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
> > Newer gcc can generate some different instances of a function
> > with suffixed symbols if the function is optimized and only
> > has a part of that. (e.g. .constprop, .part etc.)
> > In this case, it is not enough to check the entry of kprobe
> > blacklist because it only records non-suffixed symbol address.
> > To fix this issue, search non-suffixed symbol in blacklist if
> > given address is within a symbol which has a suffix.
> > Note that this can cause false positive cases if a kprobe-safe
> > function is optimized to suffixed instance and has same name
> > symbol which is blacklisted.
> > But I would like to chose a fail-safe design for this issue.
> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Why did you not add Steven's Reviewed-by tag?
The series looks fine otherwise, so I applied it with Steve's reviewed-by