Re: [PATCH 09/22] x86/fpu: Add (__)make_fpregs_active helpers
From: Borislav Petkov
Date: Wed Feb 13 2019 - 04:30:34 EST
On Thu, Feb 07, 2019 at 11:43:25AM +0100, Sebastian Andrzej Siewior wrote:
> They are accessible inside the region. But they should not be touched by
> context switch code (and later BH).
> Is that what you meant?
I just don't like that "changes" name. So when called, those functions
practically lock the FPU regs from being accessed by others. So with
for example, is kinda clear what's going on and you don't have to wonder
what it does.
> No. I picked up the patches, that function was named like that. I kept
> it. That __ probably denotes that it is an internal function but then it
> has to be used outside (KVM) if they plan to "reload" registers (which
> happens if they switch between host/guest registers).
Ok, so you can drop the "__".
Good mailing practices for 400: avoid top-posting and trim the reply.