Re: [PATCH] gpio: sprd: Add missing break in switch statement

From: Linus Walleij
Date: Wed Feb 13 2019 - 04:40:53 EST


On Mon, Feb 11, 2019 at 7:50 PM Gustavo A. R. Silva
<gustavo@xxxxxxxxxxxxxx> wrote:

> Fix the following warning by adding a missing break:
>
> drivers/gpio/gpio-eic-sprd.c: In function âsprd_eic_irq_set_typeâ:
> drivers/gpio/gpio-eic-sprd.c:403:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> switch (flow_type) {
> ^~~~~~
> drivers/gpio/gpio-eic-sprd.c:435:2: note: here
> default:
> ^~~~~~~
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Patch applied with Baolin's review tag.

Yours,
Linus Walleij