Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core

From: Bhardwaj, Rajneesh
Date: Wed Feb 13 2019 - 10:50:07 EST

On 13-Feb-19 9:03 PM, Andy Shevchenko wrote:
On Wed, Feb 13, 2019 at 5:08 PM Rajneesh Bhardwaj
<rajneesh.bhardwaj@xxxxxxxxxxxxxxx> wrote:
This patch series provides Icelake support for PMC Core driver and while
doing so it introduces the Icelake Mobile to intel-family.h as per the
CPUID from below Coreboot link
and provides some fixes and enhancements to the driver.
It's not applicable to my tree.

Hi Andy, I could apply and test in on latest upstream so i think its probably because you have applied 5 patches from v1 on your tree.

I sent the whole series again since referred to a wrong commit for Fixes:. If you want to address that by rebasing then can you please just consider patches 6-10.

Please let me know if there is any other issue?

Changes in v2:
* Addressed review comments from Thomas
* Added tags revieved
* Folded in SHA1 suggestions from Stephen Rothwell, though Andy might want to
fix it via rebasing
* Rebased and tested with Linux v5.0.0-rc6

This series:
- Adds ICL U/Y CPUID to intel-family.h
- Enables PMC driver for ICL
- Introduces a new "package cstate show" feature
- Fixes a customer issue related to S0ix on latest HP laptops
- Fixes some minor bugs

Rajneesh Bhardwaj (10):
platform/x86: intel_pmc_core: Handle CFL regmap properly
platform/x86: intel_pmc_core: Fix PCH IP sts reading
platform/x86: intel_pmc_core: Fix PCH IP name
platform/x86: intel_pmc_core: Fix file permissions for ltr_show
platform/x86: intel_pmc_core: Include Reserved IP for LTR
x86/cpu: Add Icelake to Intel family
platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro
platform/x86: intel_pmc_core: Add ICL platform support
platform/x86: intel_pmc_core: Add Package cstates residency info
platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown

arch/x86/include/asm/intel-family.h | 2 +
drivers/platform/x86/intel_pmc_core.c | 155 +++++++++++++++++++++-----
drivers/platform/x86/intel_pmc_core.h | 14 ++-
3 files changed, 145 insertions(+), 26 deletions(-)