Re: [PATCH] tracing/probes: Mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Wed Feb 13 2019 - 13:19:01 EST




On 2/13/19 8:04 AM, Steven Rostedt wrote:
> On Tue, 12 Feb 2019 15:10:40 -0600
> "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> wrote:
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> kernel/trace/trace_probe.c: In function âparse_probe_argâ:
>> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> arg++; /* Skip '+', because kstrtol() rejects it. */
>> ~~~^~
>> kernel/trace/trace_probe.c:303:2: note: here
>> case '-':
>> ^~~~
>
> I also already applied this patch (still need to run through tests)
>
> http://lkml.kernel.org/r/20190114203039.16535-1-malat@xxxxxxxxxx
>

Oh, that's great. :)

Thanks
--
Gustavo