[PATCH 4.19 06/44] tools: iio: iio_generic_buffer: make num_loops signed
From: Greg Kroah-Hartman
Date: Wed Feb 13 2019 - 13:44:21 EST
4.19-stable review patch. If anyone has any objections, please let me know.
From: Martin Kelly <mkelly@xxxxxxxx>
commit b119d3bc328e7a9574861ebe0c2110e2776c2de1 upstream.
Currently, num_loops is unsigned, but it's set by strtoll, which returns a
(signed) long long int. This could lead to overflow, and it also makes the
check "num_loops < 0" always be false, since num_loops is unsigned.
Setting num_loops to -1 to loop forever is almost working because num_loops
is getting set to a very high number, but it's technically still incorrect.
Fix this issue by making num_loops signed. This also fixes an error found
Signed-off-by: Martin Kelly <mkelly@xxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Fixes: 55dda0abcf9d ("tools: iio: iio_generic_buffer: allow continuous looping")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
tools/iio/iio_generic_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -330,7 +330,7 @@ static const struct option longopts =
int main(int argc, char **argv)
- unsigned long long num_loops = 2;
+ long long num_loops = 2;
unsigned long timedelay = 1000000;
unsigned long buf_len = 128;