Re: [PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices
From: Baolin Wang
Date: Wed Feb 13 2019 - 21:01:12 EST
On Wed, 13 Feb 2019 at 22:28, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wed, Feb 13, 2019 at 1:57 PM Baolin Wang <baolin.wang@xxxxxxxxxx> wrote:
> > We should use SoC compatible string in stead of wildcard string for
> > PMIC child devices.
> > Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
> Looks good. I had a look at arch/arm64/boot/dts/sprd/sc2731.dtsi
> as well, which contains lines such as
> compatible = "sprd,sc27xx-efuse", "sprd,sc2731-efuse";
> which fortunately work with both variants of the driver.
> Just to make sure we have the same understanding though:
> - Other drivers will leave out the 27xx part and just do
> compatible = sprd,sc2732-efuse", "sprd,sc2731-efuse";
> - When you specific a generic name (such as the sc2731 part),
> the more specific one (e.g. sc2732) needs to come /first/.
> The current DT appears to have those mixed up.
Yes, that's the conclusion we made. And I've send patches to remove
the 27xx part in drivers. Thanks for your help.