Re: [PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons

From: Martin K. Petersen
Date: Wed Feb 13 2019 - 22:14:35 EST


> - qpti->is_pti = strcmp(qpti->prom_name, "QLGC,isp");
> + qpti->is_pti = !of_node_name_eq(op->dev.of_node, "QLGC,isp");

The apparent polarity inversion made me blink but it appears to be
correct (is_pti is set if it's not an isp controller). Makes me wonder
if the driver is doing the right thing for a "SUNW,isp", though...

Meelis: Do you have anything that identifies itself as SUNW,isp?

In any case: Applied to 5.1/scsi-queue.

Martin K. Petersen Oracle Linux Engineering