Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

From: Gao Xiang
Date: Thu Feb 14 2019 - 02:11:06 EST




On 2019/2/14 14:46, Sheng Yong wrote:
> If it fails to read a shared xattr page, the inode's shared xattr array
> is not freed. The next time the inode's xattr is accessed, the previously
> allocated array is leaked.
>
> Signed-off-by: Sheng Yong <shengyong1@xxxxxxxxxx>

LGTM,

Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@xxxxxxxxxxxxxxx> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@xxxxxxxxxx>

[and there is also another race condition in it, but different root cause.
let me fix it later independently...]

Thanks,
Gao Xiang