RE: [PATCH net-next 3/3] enetc: Add ENETC PF level external MDIO support
From: Claudiu Manoil
Date: Thu Feb 14 2019 - 10:48:52 EST
>From: Andrew Lunn <andrew@xxxxxxx>
>Sent: Wednesday, February 13, 2019 8:13 PM
>To: Claudiu Manoil <claudiu.manoil@xxxxxxx>
>Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; David S .
>Miller <davem@xxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Alexandru
>Marginean <alexandru.marginean@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
>Subject: Re: [PATCH net-next 3/3] enetc: Add ENETC PF level external MDIO
>> +static int enetc_mdio_write(struct mii_bus *bus, int phy_id, int regnum,
>> + u16 value)
>> + struct enetc_mdio_regs __iomem *regs = bus_to_enetc_regs(bus);
>> + u32 mdio_ctl, mdio_cfg;
>> + u16 dev_addr;
>> + int ret;
>> + mdio_cfg = MDIO_CFG_CLKDIV(ENETC_MDC_DIV) | MDIO_CFG_NEG;
>What does MDIO_CFG_NEG mean?
I'll add a comment in the code to clarify this define.
It means the MDIO is driven by master on MDC negative edge, which is how
the external mdio busses work on this hardware. For internal MDIO CFG_NEG is 0.
>Maybe MDIO_CFG_ENC could be called MDIO_CFG_C45? Assuming that is what
>it actually means?
You're right, in the hardware manual this bit is actually called "ENC45", so
I'll change the define name to that. Should be more clear like this.
>It is a good idea to have an mdio node which contains the list of
>PHYs. You can get into odd situations if you don't do that.
Hopefully this doesn't complicate things since these are not platform devices.
It's not as easy as adding new platform device driver for mdio...
Ok for the rest of the comments too.
Thanks for the review.