Re: Fwd: [RFC v1 0/3] Address potential user-after-free on module unload

From: Sven Van Asbroeck
Date: Thu Feb 14 2019 - 12:52:23 EST


Hello Julia,

On Fri, Feb 8, 2019 at 1:57 AM Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
> > - is this important enough to ping back to authors of affected modules?
> > - should this be added to the kernel as part of 'make coccicheck' ?
> > - does this result make people "feel better" about devm_init_work() ?
>
> If the answer to the other two questions is yes, then the answer to the
> second question is yes as well.

Some maintainers seem to accept the patches created to fix the issues
flagged by this script. So maybe it's worthwhile to try and get this
into scripts/coccinelle.

Before we get started: even in a best-case scenario, the script will flag
issues which should not, or cannot be fixed. This could be because
they are false positives, or even because the author/maintainer does
not wish the issue fixed. So when the script is run, how do you 'filter out'
warnings that should be ignored? Is there anything specific I
should add to the script to accommodate this?