Re: [PATCH] psi: avoid divide-by-zero crash inside virtual machines

From: Andrew Morton
Date: Thu Feb 14 2019 - 14:59:01 EST


On Thu, 14 Feb 2019 14:31:57 -0500 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:

> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -322,7 +322,7 @@ static bool update_stats(struct psi_group *group)
> expires = group->next_update;
> if (now < expires)
> goto out;
> - if (now - expires > psi_period)
> + if (now - expires >= psi_period)
> missed_periods = div_u64(now - expires, psi_period);
>
> /*

It seems appropriate to use time_after64() and friends in this code.