Re: [PATCH] can: mark expected switch fall-throughs
From: Alexandre Belloni
Date: Thu Feb 14 2019 - 18:21:29 EST
On 14/02/2019 17:14:05-0600, Gustavo A. R. Silva wrote:
> >>> Also, the gcc documentation says that -Wimplicit-fallthrough=3
> >>> recognizes /* fallthrough */ as a proper fall through comment (and I
> >>> tested with gcc 8.2).
> >> Yeah. But that's not the relevant change in this case. Notice that the
> >> comment was moved to the very bottom of the previous case.
> > Yes and it doesn't matter for gcc, I tested with gcc 8.2.
> Yeah. But, again, you are missing the relevant part of the patch.
Right, I misread the patch and though you were moving the comment after
the case statement.
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering