Re: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support
From: Chao Yu
Date: Thu Feb 14 2019 - 21:10:46 EST
On 2019/2/3 10:52, Chao Yu wrote:
> Sorry for the delay due to business travel.
> On 2019/1/29 2:30, Dan Carpenter wrote:
>> On Tue, Jan 29, 2019 at 12:41:55AM +0800, Chao Yu wrote:
>>> Hi Dan and Xiang,
>>> On 2019-1-28 21:48, Gao Xiang wrote:
>>>> Hi Dan,
>>>> On 2019/1/28 21:33, Dan Carpenter wrote:
>>>>> Hopefully, regular kmalloc() is enough.
>>>>> Do really need the erofs_kmalloc() function? Regular kmalloc() has
>>>>> fault injection already. Have you tried to use it?
>>> Yes, I think we'd better to use erofs_kmalloc(). :)
>>> Actually, fault injection in erofs_kmalloc only affect erofs module, we can
>>> expect that the range of fault can be limited in erofs code, rather than whole
>>> kernel, so the test point can be aimed at more accurately.
>> Are you serious? The standard fault injection doesn't do that???
> Oh, I just realized the common fault injection can inject into specified
> module with function granularity, sorry.
>> Please fix it instead of creating a duplicate better implementation
>> which only your filesystem can use. I would have thought that obviously
> I agreed that it will be good to make common fault injection better,
> covering more cases, so that it can benefit all modules which need fault
> injection functionality. But rather than injecting kmalloc, there will be
> other injection demands from erofs/f2fs, like injecting in the middle of
> their specified function, how could we do that? Could you give us advice?
>> any fault injection framework could at least be configured to test
>> specific code...
>> dan carpenter