Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support

From: Andrew Lunn
Date: Fri Feb 15 2019 - 09:56:30 EST


> Hi,
> I don't really see what bindings would need to be documented, as the node
> names and properties used so far are common. Like, the "mdio" node name
> is common, the enetc ports are "pci" nodes, nothing special for these.
> What's missing?

Hi Claudiu

It is not well defined where to put phy nodes. Some drivers do allow
them directly in the MAC node, some drivers optionally allow an mdio
sub-node, others enforce an mdio sub-node. The name of the sub-node is
also not well defined.

So just documenting that the mdio sub-node is mandatory will help
people writing device trees for their boards.

Andrew