Re: [Xen-devel][PATCH 1/2] xen/gntdev: Do not destroy context while dma-bufs are in use

From: Oleksandr Andrushchenko
Date: Fri Feb 15 2019 - 10:35:43 EST

On 2/15/19 5:28 PM, Boris Ostrovsky wrote:
On 2/15/19 10:07 AM, Oleksandr Andrushchenko wrote:
On 2/15/19 5:03 PM, Boris Ostrovsky wrote:
On 2/14/19 9:23 AM, Oleksandr Andrushchenko wrote:
  /* DMA buffer export support. */
@@ -311,6 +317,7 @@ static void dmabuf_exp_release(struct kref *kref)
 Â dmabuf_exp_wait_obj_signal(gntdev_dmabuf->priv, gntdev_dmabuf);
ÂÂÂÂÂ list_del(&gntdev_dmabuf->next);
+ÂÂÂ fput(gntdev_dmabuf->priv->filp);
ÂÂÂÂÂ kfree(gntdev_dmabuf);
 @@ -423,6 +430,7 @@ static int dmabuf_exp_from_pages(struct
gntdev_dmabuf_export_args *args)
ÂÂÂÂÂ mutex_lock(&args->dmabuf_priv->lock);
ÂÂÂÂÂ list_add(&gntdev_dmabuf->next, &args->dmabuf_priv->exp_list);
ÂÂÂÂÂ mutex_unlock(&args->dmabuf_priv->lock);
+ÂÂÂ get_file(gntdev_dmabuf->priv->filp);
Not fget()?
fget wants file descriptor [1] and returns struct file *,
but we already have struct file*, so I use get_file [2]
which does what I need - increments the reference counter
on the file

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Thank you,
any chance we can get this for 5.1?