Re: [PATCH 1/8] dt-bindings: phy: Add Amlogic G12A USB2 PHY Bindings

From: Martin Blumenstingl
Date: Sun Feb 17 2019 - 16:58:51 EST


On Tue, Feb 12, 2019 at 4:14 PM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
>
> Add the Amlogic G12A Family USB2 OTG PHY Bindings
nit-pick: if you want to keep "OTG" in there then please add a short
description how OTG works on this PHY.
I would describe this as: "Add the Amlogic G12A Family USB2 PHY
Bindings. The PHY works for host or peripheral modes. Configuration of
the mode is part of the USBCTRL registers which are outside of the PHY
registers."

> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
with the patch description nit-pick addressed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>


Regards
Martin