Re: [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

From: Krzysztof Kozlowski
Date: Mon Feb 18 2019 - 03:17:06 EST


On Sat, 16 Feb 2019 at 02:07, Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:
>
> In case of error, the function platform_device_register_simple() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> Fixes: 7196c64c7d0c ("ASoC: samsung: i2s: Restore support for the secondary PCM")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> sound/soc/samsung/i2s.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof