Re: [PATCH 3/3] dt-bindings: arm: atmel: add binding for SAM9X60 shutdown controller

[Nicolas.Ferre]

On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote:
> From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> 
> Add documentation for SAM9X60 shutdown controller.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> index 14f319f694b7..9711052c5800 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> @@ -83,7 +83,7 @@ SHDWC SAMA5D2-Compatible Shutdown Controller
>   1) shdwc node
>   
>   required properties:
> -- compatible: should be "atmel,sama5d2-shdwc".
> +- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc".
>   - reg: should contain registers location and length
>   - clocks: phandle to input clock.
>   - #address-cells: should be one. The cell is the wake-up input index.
> @@ -95,6 +95,10 @@ optional properties:
>     microseconds. It's usually a board-related property.
>   - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
>   
> +optional properties for microchip,sam9x60-shdwc:

is it for sam9x60 only or is the optional property "debounce-delay-us" 
applicable to this SoC?

> +- atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
> +- atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.

Well, I would make clear that the only additional optional property is 
"atmel,wakeup-rtt-timer" while the 2 other optional properties still 
apply...


>   The node contains child nodes for each wake-up input that the platform uses.
>   
>   2) input nodes
> 


-- 
Nicolas Ferre