Re: [PATCH v2 13/15] ARM: dts: milbeaut: Add device tree set for the Milbeaut M10V board

From: Arnd Bergmann
Date: Mon Feb 18 2019 - 07:09:48 EST


On Fri, Feb 8, 2019 at 1:28 PM Sugaya Taichi
<sugaya.taichi@xxxxxxxxxxxxx> wrote:
> +
> + aliases {
> + serial1 = &uart1;
> + };

Maybe start with serial0 here? It seems unusual to start
counting at 1.

> + chosen {
> + bootargs = "init=/sbin/finit rootwait earlycon";

The /sbin/finit argument seems user space specific, so you probably don't
want this in the dts file but rather pass it from the boot loader.
Possible drop the bootargs entirely.

Arnd